Skip to content

chore: sync lora implementation with upstream #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
emergenz wants to merge 1 commit into
base: rayless-sft
Choose a base branch
from
Open

chore: sync lora implementation with upstream #10

emergenz wants to merge 1 commit into from

Conversation

@emergenz
Copy link

@emergenz emergenz commented Dec 31, 2025 •
edited
Loading

We are currently using our own LoRA implementation, while miles will rely on PEFT as soon as their implementation is merged into main. Thus we should migrate to PEFT. Also, we should match the code structure of the two PRs in order to avoid merge conflicts as much as possible down the line.

Miles LoRA PRs:

radixark#377

radixark#326

Changes

Aspect Old New (PR 326 compatible)
Enable LoRA --use-lora flag --lora-rank > 0
Target modules --lora-target-modules --target-modules
LoRA detection args.use_lora is_lora_model(model)
Checkpoint dir checkpoint_dir/ checkpoint_dir/adapter/
State dict key "model" "adapter" (when LoRA)
LoRA library Custom LoRALinear PEFT library

@emergenz emergenz mentioned this pull request Dec 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maharajamihir maharajamihir Awaiting requested review from maharajamihir

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emergenz